OpenStack Projects How to submit new changes after review from review.openstack.org
1)
#git remote -v
gerrit ssh://sajuptpm@review.openstack.org:29418/openstack/python-keystoneclient.git (fetch)
gerrit ssh://sajuptpm@review.openstack.org:29418/openstack/python-keystoneclient.git (push)
origin https://github.com/openstack/python-keystoneclient.git (fetch)
origin https://github.com/openstack/python-keystoneclient.git (push)
2)
#git branch
* bug/1047867
master
3)
Make your new changes for the bug "bug/1047867".
Then, Commit your changes
#git commit -a --amend
or
#git commit file1 file2 --amend
* We are using --amend, because this fix is part of our lat commit.
* So we can append this changes to last commit and use the message lat commit.
4)
Goto master branch
#git checkout master
5)
#git branch
bug/1047867
* master
6)
Update master branch of remote 'origin'
#git pull origin master
7)
Goto "bug/1047867" branch
#git checkout bug/1047867
8)
#git rebase -i master
This command does following operations
*Take backup of last commit from the branch "bug/1047867"
*Apply all changes from "master" branch to "bug/1047867"
*Apply backup-ed commit back to the branch "bug/1047867"
9)
Run 'git log', You can see your commit in the first place.
#git log
10)
Now your branch "bug/104786" is updated
11)
Make your new changes (related to bug:104786) in "bug/104786" branch
12)
Run following testings
*Unit test
#./run_tests.sh
*PEP8 cleaning
#./run_tests.sh --pep8
or
./run_tests.sh -d
./run_tests.sh -p
13)
Make your changes (In any) for the bug "bug/1047867".
Then, Commit your changes
#git commit -a --amend
or
#git commit file1 file2 --amend
* We are using --amend, because this fix is part of our lat commit.
* So we can append this changes to last commit and use the message lat commit.
14)
Upload your changes to Gerrit for review
#git review
15)
Goto https://review.openstack.org and login
There you can see your changes and status of review.
1)
#git remote -v
gerrit ssh://sajuptpm@review.openstack.org:29418/openstack/python-keystoneclient.git (fetch)
gerrit ssh://sajuptpm@review.openstack.org:29418/openstack/python-keystoneclient.git (push)
origin https://github.com/openstack/python-keystoneclient.git (fetch)
origin https://github.com/openstack/python-keystoneclient.git (push)
2)
#git branch
* bug/1047867
master
3)
Make your new changes for the bug "bug/1047867".
Then, Commit your changes
#git commit -a --amend
or
#git commit file1 file2 --amend
* We are using --amend, because this fix is part of our lat commit.
* So we can append this changes to last commit and use the message lat commit.
4)
Goto master branch
#git checkout master
5)
#git branch
bug/1047867
* master
6)
Update master branch of remote 'origin'
#git pull origin master
7)
Goto "bug/1047867" branch
#git checkout bug/1047867
8)
#git rebase -i master
This command does following operations
*Take backup of last commit from the branch "bug/1047867"
*Apply all changes from "master" branch to "bug/1047867"
*Apply backup-ed commit back to the branch "bug/1047867"
9)
Run 'git log', You can see your commit in the first place.
#git log
10)
Now your branch "bug/104786" is updated
11)
Make your new changes (related to bug:104786) in "bug/104786" branch
12)
Run following testings
*Unit test
#./run_tests.sh
*PEP8 cleaning
#./run_tests.sh --pep8
or
./run_tests.sh -d
./run_tests.sh -p
13)
Make your changes (In any) for the bug "bug/1047867".
Then, Commit your changes
#git commit -a --amend
or
#git commit file1 file2 --amend
* We are using --amend, because this fix is part of our lat commit.
* So we can append this changes to last commit and use the message lat commit.
14)
Upload your changes to Gerrit for review
#git review
15)
Goto https://review.openstack.org and login
There you can see your changes and status of review.
https://github.com/openstack/horizon/blob/master/doc/source/contributing.rst
ReplyDelete